Fall back to sonar-project.properties for the project key - #118
Open
Bazooper-blip wants to merge 1 commit into
Open
Fall back to sonar-project.properties for the project key#118Bazooper-blip wants to merge 1 commit into
Bazooper-blip wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58.
When no project key is set in the DelphiLint project options, the key is now read from
sonar.projectKeyinsonar-project.properties(respecting the existing "Read sonar-project.properties if present" project option, since the fallback goes throughProjectPropertiesPath).TLintProjectOptions.EffectiveSonarHostProjectKeyreturns the configured key, falling back to a minimal parse of the properties file (comments, blank lines, and whitespace handled; firstsonar.projectKeywins).DelphiLint.Analyzer(analysis options and rule retrieval, including token lookup) use the effective key..delphilintfile remains the single source of truth for what the user has set.Testing: new
DelphiLintTest.ProjectOptionsDUnitX fixture with six tests covering precedence, the fallback, the read-properties toggle, and parser edge cases (comments, whitespace, similarly named keys). Full client suite passes at the same rate as master.