Skip to content

performance-tools: Added benchnarking scripts for digital signage - #256

Open
pooja-intel wants to merge 5 commits into
intel-retail:mainfrom
pooja-intel:feature/pooja/benchmark_digitalsignage
Open

performance-tools: Added benchnarking scripts for digital signage#256
pooja-intel wants to merge 5 commits into
intel-retail:mainfrom
pooja-intel:feature/pooja/benchmark_digitalsignage

Conversation

@pooja-intel

@pooja-intel pooja-intel commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Changes:
benchmark-scripts - Added benchmarking scripts for digital signage

PR Checklist

  • Added label to the Pull Request for easier discoverability and search
  • Commit Message meets guidelines as indicated in the URL https://github.com/intel-retail/performance-tools/blob/main/CONTRIBUTING.md
  • Every commit is a single defect fix and does not mix feature addition or changes
  • Unit Tests have been added for new changes
  • Updated Documentation as relevant to the changes
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with repository license and clearly outlined the added dependency.
  • PR change contains code related to security
  • PR introduces changes that breaks compatibility with other modules (If YES, please provide details below)

What are you changing?

Issue this PR will close

close: # https://jira.devtools.intel.com/browse/ITEP-95973

Anything the reviewer should know when reviewing this PR?

Test Instructions if applicable

make benchmark-all

If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )

intel-retail/digital-signage#137

@pooja-intel
performance-tools: Added benchnarking scripts for digital signage
90fa258 
Changes:
 benchmark-scripts - Added scripts for digital signage

Signed-off-by: Pooja Kumbharkar <pooja.kumbharkar@intel.com>
@pooja-intel
pooja-intel requested review from sathyendranv, tanvidhola-ux and vkb1 and a balanced review from Copilot October 15, 2026 09:31
Copilot AI reviewed Oct 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Missing benchmark input, working-directory-dependent restarts, and startup measurement timing prevent reliable execution and results.

4 open findings
What changed in this PR

Adds digital-signage benchmark scripts to performance-tools for measuring running services.

Changes:

  • Measures Web UI selection timing and PID pipeline performance.
  • Benchmarks Qdrant scaling, ad indexing, ASe search, and AIG generation.
  • Exports measurements as JSON and CSV.
File Description
benchmark-scripts/​benchmark_web_ui.py Collects and combines per-frame selection timings.
benchmark-scripts/​benchmark_qdrant.py Measures vector search scaling and ad indexing.
benchmark-scripts/​benchmark_pid.py Samples MQTT frames and container resource usage.
benchmark-scripts/​benchmark_aig.py Measures search and image-generation latency.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread benchmark-scripts/benchmark_signage_aig.py Outdated
Comment thread benchmark-scripts/benchmark_pid.py Outdated
Comment thread benchmark-scripts/benchmark_qdrant.py Outdated
Comment thread benchmark-scripts/benchmark_signage_pid.py
@pooja-intel
performance-tools: Updated benchmarking ds scripts
de676b5 
Signed-off-by: Pooja Kumbharkar <pooja.kumbharkar@intel.com>
vkb1
vkb1 reviewed Oct 15, 2026
View reviewed changes

@vkb1 vkb1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pooja-intel .

Rest all changes looks good, just left some minor comments.

Can you share the benchmarking results after uploading to sharepoint?

Comment thread benchmark-scripts/benchmark_signage_aig.py
@@ -0,0 +1,161 @@
"""Benchmark ASe search and AIG image generation through the HTTP API."""

@vkb1 vkb1 Oct 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the copyright header.
Applies to all the new files.

Let's rename the files to have _signage suffice at the end so we know these scripts

@vkb1 vkb1 Oct 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid the newly added change would come as module docs, let's add as like we do in all our projects.

Copyright (C) 2026 Intel Corporation.

SPDX-License-Identifier: Apache-2.0

@pooja-intel pooja-intel Oct 19, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, updated the header

@sumanaga

sumanaga commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@pooja-intel Please fill in the below sections in the PR body:

  1. PR Checklist
  2. Issue this PR will close
    close: #issue_number
  3. Anything the reviewer should know when reviewing this PR?
  4. Test Instructions if applicable
  5. If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )

@pooja-intel
benchmark-scripts: Renamed the digital signage scripts
b62dcc7 
Changes:
 benchmark-scripts - Renamed the digital signage benchmarking scripts to benchmarkinmg_signage_*.py and added summary for aig and qdrant services.

Signed-off-by: Pooja Kumbharkar <pooja.kumbharkar@intel.com>
@pooja-intel
benchmark-scripts: Added license header for digital signage
4052cb9 
Changes:
  benchmark-scripts - Added license header for digital signage scripts

Signed-off-by: Pooja Kumbharkar <pooja.kumbharkar@intel.com>
@vkb1 vkb1 changed the title WIP performance-tools: Added benchnarking scripts for digital signage performance-tools: Added benchnarking scripts for digital signage Oct 16, 2026
vkb1
vkb1 reviewed Oct 16, 2026
View reviewed changes

@vkb1 vkb1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pooja-intel ,
I'm going

Comment thread benchmark-scripts/benchmark_signage_aig.py
@@ -0,0 +1,161 @@
"""Benchmark ASe search and AIG image generation through the HTTP API."""

@vkb1 vkb1 Oct 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid the newly added change would come as module docs, let's add as like we do in all our projects.

Copyright (C) 2026 Intel Corporation.

SPDX-License-Identifier: Apache-2.0

@pooja-intel
performance-tools: Updated copyright header for digital signage files
6e4eca0 
Changes:
 benchmark-scripts-Updated the copyright header for digital signage scripts

Signed-off-by: Pooja Kumbharkar <pooja.kumbharkar@intel.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkb1 vkb1 vkb1 left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@sathyendranv sathyendranv Awaiting requested review from sathyendranv
@tanvidhola-ux tanvidhola-ux Awaiting requested review from tanvidhola-ux
@sumanaga sumanaga Awaiting requested review from sumanaga

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pooja-intel @sumanaga @vkb1