Repository navigation
refactor(performance-tools): log camera config metadata - #257
Open
rishika-y-gaur wants to merge 2 commits into
Open
rishika-y-gaur wants to merge 2 commits into
rishika-y-gaur wants to merge 2 commits into
Conversation
Read the _about section from the selected camera config and print its scenario details at the start of terminal output and stream_density.log. Add tests for loading and printing the metadata and including it in the stream-density report. Resolves 344 and 369 Signed-off-by: rishika-y-gaur <rishika.gaur@intel.com>
5 of 8 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Production report calls omit the metadata argument, leaving scenario details absent from result summaries.
1 open finding
What changed in this PR
Adds camera configuration scenario metadata to stream-density output.
Changes:
- Loads optional
_aboutmetadata and prints it at terminal and log startup. - Adds report metadata formatting and unit tests.
| File | Description |
|---|---|
| benchmark-scripts/stream_density.py | Loads and prints scenario metadata; adds optional report fields. |
| benchmark-scripts/stream_density_test.py | Tests metadata loading, printing, and report formatting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pass the selected camera config's _about metadata to both production stream-density report calls. Add iteration-level coverage for successful-density and minimum-pipeline failure reports. Signed-off-by: rishika-y-gaur <rishika.gaur@intel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Read the _about section from the selected camera config and print its scenario details at the start of terminal output and stream_density.log. Add tests for loading and printing the metadata and including it in the stream-density report.
Resolves 344 and 369
PR Checklist
What are you changing?
Read the optional
_aboutsection from the selected camera config and print its scenario details at the start of terminal output andstream_density.log. Add tests for loading and printing the metadata and including it in the stream-density report.Issue this PR will close
close: #344 and #369
Anything the reviewer should know when reviewing this PR?
Camera configs without an
_aboutsection remain supported. The log is opened in append mode, so the metadata appears at the start of each run’s log output, not necessarily at the top of an existing log file. All repository references to the renamed and removed workloads have been updated; no compatibility break is expected.Test Instructions if applicable
From
performance-tools/benchmark-scripts, run these three test casespython -m unittest
stream_density_test.Testing.test_get_camera_config_about_reads_selected_config
stream_density_test.Testing.test_print_camera_config_about_shows_selected_config_and_fields
stream_density_test.Testing.test_print_stream_density_report_summary
stream_density_test.Testing.test_pipeline_iterations
If the there are associated PRs in other repositories, please link them here (i.e. intel-retail/performance-tools )