BM/pstate: Fix balance_performance EPP check on EMR - #593
Merged
Merged
Conversation
intel_pstate_tests08 sets energy_performance_preference to
balance_performance and then verifies the EPP request value reported by
x86_energy_perf_policy. The test currently treats only Sapphire Rapids
model 143 as using EPP 32, so Emerald Rapids model 207 falls back to the
legacy expected value 128.
The upstream Linux change 64a66f4a3c89 ("cpufreq: intel_pstate: Update
Balance performance EPP for Emerald Rapids") changed Emerald Rapids to
use the same balance_performance EPP value as Sapphire Rapids, 32. Update
the LKVS expectation for model 207 to match the kernel behavior.
Signed-off-by: Yijia Wang <wangyijia.yeah@bytedance.com>
…ts.sh These SC2155/SC2004/SC2034 warnings are not introduced by this PR but block CI since the file is now lint-checked. Clean them up. Co-authored-by: TRAE CLI <traecli@bytedance.com>
Contributor
Author
|
CI flagged 4 pre-existing shellcheck issues in this file; fixed them along the way (no behavior change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intel_pstate_tests08verifies the EPP request value after settingenergy_performance_preferencetobalance_performance.The test currently expects EPP value
32only on Sapphire Rapids(model 143). On Emerald Rapids (model 207), it falls back to the legacy
expected value
128, but the current kernel behavior is to use32.The upstream Linux change 64a66f4a3c89 ("cpufreq: intel_pstate: Update
Balance performance EPP for Emerald Rapids") changed Emerald Rapids to
use the same
balance_performanceEPP value as Sapphire Rapids.Update the LKVS expectation for model 207 to match the kernel behavior.
Validation
I have done:
git diff --check origin/main..HEADbash -n BM/pstate/intel_pstate_tests.shscripts/checkpatch.pl --strict 0001-BM-pstate-Fix-balance_performance-EPP-check-on-EMR.patch./intel_pstate_tests.sh -t verify_gov_powersave_epp_balance_perfon an Emerald Rapids system, model 207. Passed.
The EMR run reported CPU model 207, read EPP value
32, and completedwith
check_epp_req PASS.Signed-off-by: Yijia Wang wangyijia.yeah@bytedance.com