Repository navigation
[SYCL][NFC] Promote new-style property engine base to sycl::detail - #23064
Merged
KornevNikita merged 1 commit intoSep 1, 2026
Merged
Conversation
koparasy
force-pushed
the
khr/properties/promote-engine-to-detail
branch
from
August 31, 2026 21:42
b18576a to
baba5ee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the “new-style” property-definition engine (PropKind registry + base classes) into sycl::detail so it can be shared between sycl::ext::oneapi::experimental and an upcoming sycl::khr properties layer (prep work for KhronosGroup/SYCL-Docs#980).
Changes:
- Adds a new shared engine header at
<sycl/detail/properties/property.hpp>definingsycl::detail::PropKindand the property key/value base infrastructure. - Updates the
ext::oneapi::experimentalfacade header to include the shared engine and re-export the specific engine types intoexperimental::detail. - Adjusts dependent code/tests to reference the promoted engine (
PropertyIDspecialization placement,PropKindscoped enumerators, ABI layout expectations).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sycl/test/abi/sycl_classes_abi_neutral_test.cpp | Updates ABI-neutral record-layout checks to expect the base class in sycl::detail. |
| sycl/include/sycl/ext/oneapi/properties/property.hpp | Switches to the shared sycl::detail property engine and re-exports engine symbols into experimental::detail. |
| sycl/include/sycl/ext/oneapi/properties/property_value.hpp | Moves PropertyID specialization for property_value to sycl::detail (namespace of the primary). |
| sycl/include/sycl/ext/oneapi/experimental/cluster_group_prop.hpp | Updates the property kind argument to use the now-scoped PropKind::ClusterLaunch. |
| sycl/include/sycl/detail/properties/property.hpp | Introduces the shared property-definition engine in sycl::detail. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
slawekptak
approved these changes
Sep 1, 2026
Contributor
Author
|
@intel/llvm-gatekeepers test failures look unrelated. Can you merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation of implementing: KhronosGroup/SYCL-Docs#980