Repository navigation
Harden report rendering, indicator loading and browser parsing - #9
Merged
Merged
Conversation
Report: sanitise artifact-derived text before rendering. Control characters, line separators and bidirectional overrides are replaced and newlines collapse to spaces, so a crafted profile name or registry value cannot forge report lines. The privacy note now appears on every report, not only on ones with findings. Indicators: reject values that are not hostnames, IP addresses or hex digests, including empty, unspecified and over-long values, and cap the indicator count. Browser: treat deeply nested JSON as a malformed artifact instead of aborting the module, and refuse oversized databases before copying them. CLI: refuse --iocs and --json paths that are not on a local disk. Remove the unused write-mode module and an unused quoting helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening fixes from the pre-release security review. Each change is small and independently tested.
0.0.0.0,::) and over-long values. Indicator count is capped. All 405 shipped indicators still load.--iocsand--jsonpaths not on a local disk are refused before anything is opened. Relative paths such as--json report.jsonstill work.Testing