fix: updates to grammars/scanners to fix bugs found in healthshare te… - #54
Merged
hkimura-intersys merged 4 commits intoAug 31, 2026
Merged
Conversation
…sting.
Errors fixed:
1. Add ZenMethod keyword, missing relationship keywords,
2. Added ClientMethod (also known as ClassClientMethod)
3. Allow do with a macro
4. Allow statements to be a macro arg
5. Allow macros as json literals
6. Change parsing of ZW_BLOCK and ARGUMENTLESS_LOOP in scanner to account for if {hi} {} cases
7. Combined external language parsing into one function, and used flags to differentiate when needed.
8. Parse mimetype with scanner and token (scanner for python or text to set needed flags).
9. Allowed optional argument in property
10. Add #EXECUTE to statement options
11. Allow macro.prop as class name
12. Allow #IF, #ENDIF, #ELSE to start on any col
13. Allow macros in oref_chain_segment
14. allow () in foreignkey without the index name
15. Fix parsing Property with arguments
16. Fix Index Type parsing
17. Allow * as a arg to a macro function
18. Allow macro.prop as class name
hkimura-intersys
requested review from
davem-intersys
and removed request for
davem-intersys
August 31, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes errors found when testing tree-sitter with files from //projects/healthshare/
Changes:
1. Add ZenMethod keyword, missing relationship keywords,
2. Added ClientMethod (also known as ClassClientMethod)
3. Allow do with a macro
4. Allow statements to be a macro arg
5. Allow macros as json literals
6. Change parsing of ZW_BLOCK and ARGUMENTLESS_LOOP in scanner to account for if {hi} {} cases
7. Combined external language parsing into one function, and used flags to differentiate when needed.
8. Parse mimetype with scanner and token (scanner for python or text to set needed flags).
9. Allowed optional argument in property
10. Add #EXECUTE to statement options
11. Allow macro.prop as class name
12. Allow #IF, #ENDIF, #ELSE to start on any col
13. Allow macros in oref_chain_segment
14. allow () in foreignkey without the index name
15. Fix parsing Property with arguments
16. Fix Index Type parsing
17. Allow * as a arg to a macro function
18. Allow macro.prop as class name
The updated grammars/scanners have been tested on all files in //projects/healthshare as well as all files in %SYS and //projects/sql