Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis release-branch change updates the plugin’s Jellyfin dependencies from the 12.0 release candidate to stable 12.1, retaining the net10.0 build and runtime exclusions, and aligns both package metadata and documentation with the new minimum server ABI. Review the dependency diff for compatibility with Jellyfin 12.1 and confirm the stated build, packaging, and embedded-resource validation; the frontend prerequisite remains external to this PR. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The build check is failing on the five existing frontend TypeScript errors, before the .NET build. The log confirms it still compiles the old |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by gpt-5.6-luna · Input: 0 · Output: 0 · Cached: 0 |
Update Jellyfin.Controller and Jellyfin.Model from 12.0.0-rc2 to stable 12.1.0, preserving the existing .NET 10 target and runtime asset exclusions. Align the minimum ABI and documented server requirement with Jellyfin 12.1.
Targets the existing
12.0release branch so the 10.11 build on master is unchanged.Depends on intro-skipper/segment-editor#244: current release failures occur first in the frontend TypeScript build, so that fix must reach frontend master before this PR’s build check can pass. No workflow bypasses or temporary frontend branch pins are included.
Verified locally with the fixed frontend: .NET restore, Release build (zero warnings/errors), format verification, and ZIP packaging. The solution’s dotnet test command completes but has no test project. Loaded the final DLL in Jellyfin Server 12.1.0 and verified all 68 embedded files are served byte-for-byte.
Summary by Sourcery
Align the Segment Editor plugin with the stable Jellyfin 12.1 release while preserving its existing .NET 10 build target.
Bug Fixes:
Enhancements:
Documentation: