Skip to content

fix: build against stable Jellyfin 12.1 - #18

Closed
rlauuzo wants to merge 1 commit into
12.0from
fix/jellyfin-12.1-builds
Closed

rlauuzo wants to merge 1 commit into
12.0from
fix/jellyfin-12.1-builds

Conversation

@rlauuzo

@rlauuzo rlauuzo commented Sep 17, 2026

Copy link
Copy Markdown
Member

Update Jellyfin.Controller and Jellyfin.Model from 12.0.0-rc2 to stable 12.1.0, preserving the existing .NET 10 target and runtime asset exclusions. Align the minimum ABI and documented server requirement with Jellyfin 12.1.

Targets the existing 12.0 release branch so the 10.11 build on master is unchanged.

Depends on intro-skipper/segment-editor#244: current release failures occur first in the frontend TypeScript build, so that fix must reach frontend master before this PR’s build check can pass. No workflow bypasses or temporary frontend branch pins are included.

Verified locally with the fixed frontend: .NET restore, Release build (zero warnings/errors), format verification, and ZIP packaging. The solution’s dotnet test command completes but has no test project. Loaded the final DLL in Jellyfin Server 12.1.0 and verified all 68 embedded files are served byte-for-byte.

Open in Capy

Summary by Sourcery

Align the Segment Editor plugin with the stable Jellyfin 12.1 release while preserving its existing .NET 10 build target.

Bug Fixes:

  • Update the plugin to build against stable Jellyfin 12.1 packages.

Enhancements:

  • Raise the minimum supported Jellyfin server version and target ABI to 12.1.

Documentation:

  • Document Jellyfin Server 12.1 as the minimum requirement.

@sourcery-ai

sourcery-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This release-branch change updates the plugin’s Jellyfin dependencies from the 12.0 release candidate to stable 12.1, retaining the net10.0 build and runtime exclusions, and aligns both package metadata and documentation with the new minimum server ABI. Review the dependency diff for compatibility with Jellyfin 12.1 and confirm the stated build, packaging, and embedded-resource validation; the frontend prerequisite remains external to this PR.

File-Level Changes

Change Details Files
Upgrade Jellyfin package dependencies to the stable 12.1 release while preserving the existing build configuration.
  • Replace Jellyfin.Controller and Jellyfin.Model 12.0.0-rc2 references with 12.1.0.
  • Retain the .NET 10 target and existing runtime asset exclusions.
SegmentEditorPlugin/SegmentEditorPlugin.csproj
Raise the plugin’s declared compatibility and documented server requirement to Jellyfin 12.1.
  • Set the minimum target ABI to 12.1.0.0.
  • Update the README requirement and package changelog to describe Jellyfin 12.1 compatibility.
build.yaml
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 1 other finding in Capy.

Open in Capy

@capy-ai

capy-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The build check is failing on the five existing frontend TypeScript errors, before the .NET build. The log confirms it still compiles the old error: Error component from frontend master. Merge intro-skipper/segment-editor#244 first, then rerun this check. The combined changes already pass the local frontend and .NET builds; the final DLL loaded in Jellyfin 12.1 and served all 68 embedded files byte-for-byte.

@kilo-code-bot

kilo-code-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • README.md
  • SegmentEditorPlugin/SegmentEditorPlugin.csproj
  • build.yaml

Reviewed by gpt-5.6-luna · Input: 0 · Output: 0 · Cached: 0

@capy-ai capy-ai Bot mentioned this pull request Sep 17, 2026
@capy-ai

capy-ai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Superseded by commit 944d28f on PR #12, per the requested direct update. #12 now uses stable-only 12.* floating references, currently resolving to 12.1.0, rather than pinning a single release. Closing this duplicate without merging.

@capy-ai capy-ai Bot closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant