Feature gate for embedding data#178
Draft
abkfenris wants to merge 1 commit into
Draft
Conversation
Merged
abkfenris
force-pushed
the
phase-1-js-build-optimization
branch
from
150f479 to
2d12990
Compare
abkfenris
force-pushed
the
phase-2a-feature-gate-embedded-data
branch
from
a01a121 to
9b84003
Compare
Javascript size report
✅ Size decreased -0.3%. |
abkfenris
force-pushed
the
phase-1-js-build-optimization
branch
from
2d12990 to
a5ed33d
Compare
abkfenris
force-pushed
the
phase-2a-feature-gate-embedded-data
branch
from
9b84003 to
2fb2382
Compare
This was referenced Jun 24, 2026
Draft
Add `embedded-data` cargo feature (default) that wraps the include_bytes!/flate2 path. py/cli build with defaults unchanged. New ingestion methods accept YAML strings, JSON strings, or a pre-deserialized Vec, letting the JS wasm receive data externally. Knowledge struct Vec fields now have #[serde(default)] for partial-doc ingestion. New nox session rust_test_no_embedded verifies the no-embedded path (11 tests).
abkfenris
force-pushed
the
phase-2a-feature-gate-embedded-data
branch
from
2fb2382 to
65273d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
embedded-datacargo feature (default) that wraps theinclude_bytes!/flate2 path. py/cli build with defaults unchanged.
New ingestion methods accept YAML strings, JSON strings, or a
pre-deserialized Vec, letting the JS wasm receive data externally.
Knowledge struct Vec fields now have #[serde(default)] for partial-doc
ingestion. New nox session rust_test_no_embedded verifies the
no-embedded path (11 tests).
This is part 2 of 6 in a stack made with GitButler: