fix(srtla_send): apply the --config toml file - #21
Merged
Merged
Conversation
--config loaded the file, debug-logged it and dropped it, so no key ever took effect. Keys set in the file now fill every option not typed on the command line (command line, then file, then default). The schema now holds only the six keys that map to a flag. The other eight had nothing to feed: core constants or removed features. Unknown keys and parse errors now stop startup rather than falling back to defaults, so a stale file fails loudly instead of doing nothing. The file is read once at startup; the "reloaded on SIGHUP" claim was never true and is gone. Runtime changes go through JSON-RPC.
Contributor
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: irlserver/srtla_send/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--configloaded the TOML file, debug-logged it and dropped it. No key has ever taken effect. CodeRabbit flagged this on #18, which adds two more keys to the same dead path.Changes
value_source, so a typed flag wins even when its value equals the default.mode,no_quality,no_stall_deselect,stall_min_in_flight,stall_ack_stale_ms,conn_timeout_ms. The other eight keys had no target. Some were core constants, and others belonged to features that have since been removed.deny_unknown_fieldsis set, and a load or parse error now stops startup. Before, the loader fell back to defaults. A config file that still uses a removed key now fails loudly instead of silently doing nothing.--confighelp, the module doc and the README. SIGHUP only reloads the IP list. Use JSON-RPC to change settings at runtime.Review notes
Cli::apply_config_fileinsrc/main.rs. Thefill!macro relies on clap derive using the field name as the arg id.switch_hysteresis) now stops startup with an error that lists the valid keys. Such files never did anything before.TomlConfigand to thefill!list.