Update ISEmojiList.plist - #91
Open
HappyIosDeveloper wants to merge 2 commits into
Open
Conversation
removed comments.
There was a problem hiding this comment.
Pull request overview
Updates the project’s bundled emoji catalog (ISEmojiList.plist) to include additional emojis used by ISEmojiView.
Changes:
- Added several new emoji entries across multiple categories.
- Updated ordering/placement of a few entries within existing arrays.
Suppressed comments (5)
Sources/ISEmojiView/Assets/ISEmojiList.plist:1636
- These entries are duplicates of emojis already present earlier in this same category (🌳 at line 1565, 🐋 at line 1525, 🐾 at line 1559). Duplicates here can lead to repeated items when rendering the list.
<string>🌳</string>
<string>🐋</string>
<string>🐾</string>
Sources/ISEmojiView/Assets/ISEmojiList.plist:1750
- 🥕 is already present earlier in Food & Drink (line 1668). Duplicating it here will likely show the carrot twice in the same category.
<string>🥕</string>
Sources/ISEmojiView/Assets/ISEmojiList.plist:2182
- 🗻 is already present earlier in this same category (line 2139). Duplicating it here will likely show the same emoji twice.
<string>🗻</string>
Sources/ISEmojiView/Assets/ISEmojiList.plist:2402
- 💥, 🎺, and 📦 are duplicates of existing entries earlier in this same category (💥 at line 1609, 🎺 at line 2044, 📦 at line 2337). Duplicates here can lead to repeated emojis in the picker.
<string>💥</string>
<string>🎺</string>
<string>📦</string>
Sources/ISEmojiView/Assets/ISEmojiList.plist:2684
- 💨 is already present in the Animals & Nature section (line 1627). If the consumer expects unique emojis across the full dataset, this addition will introduce a duplicate; if duplicates are allowed, it would be good to document that invariant near the plist consumer.
<string>💨</string>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated emojis.