Skip to content

Update ISEmojiList.plist - #91

Open
HappyIosDeveloper wants to merge 2 commits into
isaced:masterfrom
HappyIosDeveloper:patch-2
Open

Update ISEmojiList.plist#91
HappyIosDeveloper wants to merge 2 commits into
isaced:masterfrom
HappyIosDeveloper:patch-2

Conversation

@HappyIosDeveloper

Copy link
Copy Markdown

Updated emojis.

removed comments.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s bundled emoji catalog (ISEmojiList.plist) to include additional emojis used by ISEmojiView.

Changes:

  • Added several new emoji entries across multiple categories.
  • Updated ordering/placement of a few entries within existing arrays.
Suppressed comments (5)

Sources/ISEmojiView/Assets/ISEmojiList.plist:1636

  • These entries are duplicates of emojis already present earlier in this same category (🌳 at line 1565, 🐋 at line 1525, 🐾 at line 1559). Duplicates here can lead to repeated items when rendering the list.
			<string>🌳</string>
			<string>🐋</string>
			<string>🐾</string>

Sources/ISEmojiView/Assets/ISEmojiList.plist:1750

  • 🥕 is already present earlier in Food & Drink (line 1668). Duplicating it here will likely show the carrot twice in the same category.
			<string>🥕</string>

Sources/ISEmojiView/Assets/ISEmojiList.plist:2182

  • 🗻 is already present earlier in this same category (line 2139). Duplicating it here will likely show the same emoji twice.
			<string>🗻</string>

Sources/ISEmojiView/Assets/ISEmojiList.plist:2402

  • 💥, 🎺, and 📦 are duplicates of existing entries earlier in this same category (💥 at line 1609, 🎺 at line 2044, 📦 at line 2337). Duplicates here can lead to repeated emojis in the picker.
			<string>💥</string>
			<string>🎺</string>
			<string>📦</string>

Sources/ISEmojiView/Assets/ISEmojiList.plist:2684

  • 💨 is already present in the Animals & Nature section (line 1627). If the consumer expects unique emojis across the full dataset, this addition will introduce a duplicate; if duplicates are allowed, it would be good to document that invariant near the plist consumer.
			<string>💨</string>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Sources/ISEmojiView/Assets/ISEmojiList.plist Outdated
Comment thread Sources/ISEmojiView/Assets/ISEmojiList.plist
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants