Refactor integration tests for improved error handling and timeout management - #119
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 95.33% 95.34% +0.01%
==========================================
Files 33 33
Lines 25312 25346 +34
==========================================
+ Hits 24130 24166 +36
+ Misses 1182 1180 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…nagement - Enhanced error handling in `snapshot_export.rs` and `ssl_connections.rs` by replacing silent failures with `expect` calls to ensure clearer test failures. - Increased timeout duration in `test_snapshot_and_stream_consistency` from 5 seconds to 60 seconds to accommodate longer operations. - Introduced a `CancellationToken` for managing timeouts in `ssl_initial_snapshot.rs` and `streaming_decode.rs`, ensuring that blocking operations can be cancelled appropriately. - Added `wait_for_slot_inactive` and `SlotGuard` in `truncate_flags.rs` and `version_preflight.rs` to prevent leaking replication slots by ensuring they are inactive before dropping. - Updated connection string handling in `stream.rs` to include a `connect_timeout` parameter, ensuring that connection attempts are bounded by a specified timeout. - Improved test assertions to provide clearer feedback on skipped tests due to version requirements or configuration settings.
isdaniel
force-pushed
the
fix/integration-test-enhancement
branch
from
September 20, 2026 14:52
f0b10ec to
1e58c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snapshot_export.rsandssl_connections.rsby replacing silent failures withexpectcalls to ensure clearer test failures.test_snapshot_and_stream_consistencyfrom 5 seconds to 60 seconds to accommodate longer operations.CancellationTokenfor managing timeouts inssl_initial_snapshot.rsandstreaming_decode.rs, ensuring that blocking operations can be cancelled appropriately.wait_for_slot_inactiveandSlotGuardintruncate_flags.rsandversion_preflight.rsto prevent leaking replication slots by ensuring they are inactive before dropping.stream.rsto include aconnect_timeoutparameter, ensuring that connection attempts are bounded by a specified timeout.