feat: Add validation step that runs on approved PR review - #50
Open
nathaniel-itential wants to merge 2 commits into
Open
feat: Add validation step that runs on approved PR review#50nathaniel-itential wants to merge 2 commits into
nathaniel-itential wants to merge 2 commits into
Conversation
Contributor
Author
|
@jennlu330 Adjusted the diff script and validation.yml script to take in a env variable called INCLUDE_ALL_SPEC_VERSIONS that decides to collect all specs or just latest specs. Not defining the variable defaults to only collecting -latest, so promotion.yml does not need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a validation step, runs on approved PR review. Adjusted diff logic to accept BASE_SHA parameter instead of hardcoding HEAD~1 commit for diff logic.
Validation.yml does the diff and artifact setup for the validation-deploy step, and runs on review approval. Validation-deploy.yml runs when validation.yml is finished, and deploys the assets to staging.