Use upstream ratatuis - #154
Merged
Merged
Conversation
Owner
Author
|
I guess we can run on our branch of mimalloc_rust for now, but I've filed purpleprotocol/mimalloc_rust#167 to fix the issue upstream. Gonna wait a day or two just in case they merge my fix in rq so that we don't ever have to rely on my fork. |
itsjunetime
force-pushed
the
june/upstream_ratatuis
branch
from
August 15, 2026 22:12
c98eed1 to
848c7f5
Compare
Owner
Author
|
Ok, it looks like the mimalloc build flag issue is a lot more complex than I anticipated, so we can't really get an easy upstream solution yet. So we'll just have to use a fork for a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that ratatui/ratatui#1116 is resolved with the latest release of ratatui, we can use upstream ratatui. Some basic testing and benchmarking shows now big issues, so this is probably good and fine.