Repository navigation
Ignore already-closed channels when shutting down publisher pools - #90
Merged
Merged
Conversation
A confirm timeout closes the channel and resets the confirms pool while the channel is still checked out. On checkin the pool's shutdown block closed it again, raising Bunny::ChannelAlreadyClosed. That masked the PublishConfirmationTimeout, and the retry handler then retried it as a connection error, risking a duplicate message. Side effects: - Confirm timeouts and nacks reach the caller and are not retried. - A pool reset by another thread no longer makes a successful publish raise on checkin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jKatt
marked this pull request as ready for review
October 1, 2026 06:50
johannesluedke
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish-confirm timeouts show up as
Bunny::ChannelAlreadyClosed: the pool closes the already-closed channel again on checkin. That hides the timeout and makes ears retry it as a connection error, which can duplicate a message.The pool shutdown block now skips channels that are already closed. Released as 0.26.1.
Note: a confirm timeout still resets the whole confirms pool; dropping only the failed channel is left for a follow-up.
🤖 Generated with Claude Code