Repository navigation
ci(release): keep the dev channel in sync after a release - #393
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
devchannel has not received a release commit since v4.5.1.promote-main-to-dev.ymlonly triggers onpushtomain, andrelease-prod.ymlpushes the version-bump commit withGITHUB_TOKEN, which starts no push workflow. Every release therefore leavesdevone commit behind, anddist-tag devdrifts further frommainover time.This adds
workflow_dispatchto the promotion workflow and dispatches it from the release workflow right after the release commit lands.Evidence
npm view @jacebenson/jsn dist-tagsreported{ latest: '5.0.0', dev: '4.5.1-dev.120.1' }whilemainwas at2335b0a chore: release v5.0.0.gh api repos/jacebenson/jsn/compare/main...devreportsbehind_by: 2,ahead_by: 0.pushate630e345(the final feature merge), before the release commits. No promotion run exists for the v5.0.0 release.promote-main-to-dev.ymlhadon: pushonly, so the documentedGITHUB_TOKENlimitation had no recovery path.main, a dispatched promotion is testable:gh workflow run promote-main-to-dev.yml --ref main.Checks
yaml.safe_load), withpromote-main-to-devnow exposing['push', 'workflow_dispatch'].release-prod.ymlis push release commit and tag, then dispatch promotion, then dispatch npm publish, then create the release.cliandsitejobs skip because no application paths changed.Merge danger
workflow_dispatchplus thev*.*.*tag.devstays whatever it is at that moment and the earlier manual-dispatch path is gone again.Limitations
main; I verified the promotion job by dispatching the branch ref, not by running the edited release workflow end to end.--force-with-leaseagainst the fetched dev SHA, so a concurrent dev write fails the job rather than being overwritten.Refs #392