Repository navigation
feat(mcp): declare review_observations read-only - #61
Merged
Merged
Conversation
Clients that gate writes treat a tool without readOnlyHint as a write, so every review prompted for approval. record_observation stays unannotated.
The comment now names the MCP default it rests on, and the prose names Claude Code plan mode rather than any approval prompt, which allow rules already satisfy outside plan mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
review_observationsnow declares itself read-only through the MCPreadOnlyHintannotation, withopenWorldHint: falsesince it reads only the local store. MCP'sreadOnlyHintdefaults to false, so a client that gates writes treats an unannotated tool as a write: Claude Code's plan mode prompted before every review, and an allow rule could not stop it.record_observationstays unannotated, so the same gate still stands in front of every write.A test pins the read/write classification of every exposed tool through a client session, so a tool added later has to be classified on purpose rather than inheriting the write default.
🤖 Generated with Claude Code