Skip to content

FIX: Manage ZooKeeper data and log directories #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviarla merged 1 commit into from
Aug 11, 2026
Merged

FIX: Manage ZooKeeper data and log directories #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions internal/zk/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package zk

import (
"fmt"
"path"
"strings"

"github.com/jam2in/arcusctl/internal"
Expand Down Expand Up @@ -77,11 +78,19 @@ func groupServersByHost(servers []topology.ZKServer) map[string][]topology.ZKSer
}

func removeHostFiles(host string, servers []topology.ZKServer, topoPath string) error {

@oliviarla oliviarla Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

각각 μ–΄λ–€ 처리λ₯Ό ν•˜λŠ”κ±΄μ§€ μ£Όμ„μ΄λ‚˜ 별도 λ©”μ„œλ“œν™”ν•˜λŠ”κ²Œ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€. ν•œλ²ˆμ— μ΄ν•΄ν•˜κΈ° μ–΄λ €μš΄ μƒνƒœλ„€μš”γ…œ

@f1v3-dev f1v3-dev Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λΆˆν•„μš”ν•˜κ²Œ μ‚¬μš©μžκ°€ μ§€μ •ν•œ data_dir, data_log_dir μƒμœ„ λ””λ ‰ν† λ¦¬κΉŒμ§€ μ •λ¦¬ν•˜λŠ” μ½”λ“œκ°€ λ“€μ–΄κ°€μžˆλ‹€λ³΄λ‹ˆ μ΄ν•΄ν•˜κΈ° μ–΄λ €μ› λ˜ 것 κ°™μŠ΅λ‹ˆλ‹€.

ν•΄λ‹Ή λ‘œμ§μ€ μ œκ±°ν•˜κ³  μ‚­μ œ λŒ€μƒμ„ μ•„λž˜μ™€ 같이 ν•œμ •ν•˜κ³ , 경둜 계산 λ‘œμ§μ„ λ”°λ‘œ λΆ„λ¦¬ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

원격 호슀트 μ‚­μ œ λŒ€μƒ

  • ZooKeeper μ„€μΉ˜ 경둜
  • λ…Έλ“œλ³„ <data_dir>/zk<myid> 및 <data_log_dir>/zk<myid> 디렉터리

paths := []string{topoPath}
removePaths := []string{topoPath}
for _, server := range servers {
paths = append(paths, fmt.Sprintf("%s/zk%d", server.Config.DataDir, server.MyID))
removePaths = append(removePaths, nodeDataPaths(server)...)
}

cmd := "rm -rf " + strings.Join(paths, " ")
return ssh.Run(host, cmd)
return ssh.Run(host, "rm -rf "+strings.Join(removePaths, " "))
}

func nodeDataPaths(server topology.ZKServer) []string {
nodeDirName := fmt.Sprintf("zk%d", server.MyID)

return []string{
path.Join(server.Config.DataDir, nodeDirName),
path.Join(server.Config.DataLogDir, nodeDirName),
}
}
11 changes: 8 additions & 3 deletions internal/zk/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,15 @@ func installArchive(host string, installPath string, version string, localTarPat
func configureServer(server topology.ZKServer, topo *topology.ZKTopology) error {
host := server.Host()
confDir := fmt.Sprintf("%s/conf_myid_%d", topo.Path, server.MyID)
dataDir := server.Config.DataDir
dataDirPath := fmt.Sprintf("%s/zk%d", dataDir, server.MyID)
dataDirPath := fmt.Sprintf("%s/zk%d", server.Config.DataDir, server.MyID)
dataLogDirPath := fmt.Sprintf("%s/zk%d", server.Config.DataLogDir, server.MyID)
mkdirCmd := fmt.Sprintf(
"mkdir -p %s %s %s",
confDir,
dataDirPath,
dataLogDirPath,
)

mkdirCmd := fmt.Sprintf("mkdir -p %s %s", confDir, dataDirPath)
if err := ssh.Run(host, mkdirCmd); err != nil {
return fmt.Errorf("mkdir on %s: %w", host, err)
}
Expand Down
Loading