Conversation
bufo24
marked this pull request as draft
September 17, 2026 09:58
bufo24
marked this pull request as ready for review
September 17, 2026 10:15
bufo24
force-pushed
the
feat/tapd-v0.8.4-rpcs
branch
from
September 17, 2026 10:17
2b5fea2 to
f9ca49b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer guide: written vs generated
Handwritten code — review these changes closely
src/channelsApi.ts— five public Taproot Asset invoice/payment methods and their version annotationssrc/rfqApi.ts— the public RFQ forwarding-history method and its version annotationUpstream proto snapshots — copied from tapd v0.8.4
protos/tapchannelrpc/tapchannel.protoprotos/rfqrpc/rfq.protoThese are source inputs copied from the upstream taproot-assets release; they are not generated or locally designed.
Generated code — 28 files
src/types/**These TypeScript definitions are generated from the committed proto snapshots. To reproduce and verify them without updating any proto files:
Do not use
yarn generatefor this check: it also runs the unchanged general proto updater, which targets the package baseline rather than the two selectively updated snapshots in this PR.Added RPCs
Rfq.ForwardingHistory— introduced in tapdv0.8.0TaprootAssetChannels.ListInvoices— introduced in tapdv0.8.1TaprootAssetChannels.ListPayments— introduced in tapdv0.8.1TaprootAssetChannels.SubscribeInvoices— introduced in tapdv0.8.1TaprootAssetChannels.SubscribePayments— introduced in tapdv0.8.1TaprootAssetChannels.TrackPayment— introduced in tapdv0.8.1Validation
yarn build