Skip to content

Add tapd Lightning payment RPCs through v0.8.4 - #9

Open
bufo24 wants to merge 5 commits into
jamaljsr:masterfrom
bufo24:feat/tapd-v0.8.4-rpcs
Open

bufo24 wants to merge 5 commits into
jamaljsr:masterfrom
bufo24:feat/tapd-v0.8.4-rpcs

Conversation

@bufo24

@bufo24 bufo24 commented Sep 17, 2026

Copy link
Copy Markdown

Summary

  • add the tapd v0.8.4 Taproot Asset Channels and RFQ proto snapshots needed by the Lightning payment environment
  • generate TypeScript types for those selected schemas
  • expose invoice/payment listing and streaming, payment tracking, and RFQ forwarding history through the high-level client
  • annotate each new public method with the stable tapd version that first included its RPC
  • leave the package version, lnd protos, and general proto updater unchanged

Reviewer guide: written vs generated

Handwritten code — review these changes closely

  • src/channelsApi.ts — five public Taproot Asset invoice/payment methods and their version annotations
  • src/rfqApi.ts — the public RFQ forwarding-history method and its version annotation

Upstream proto snapshots — copied from tapd v0.8.4

  • protos/tapchannelrpc/tapchannel.proto
  • protos/rfqrpc/rfq.proto

These are source inputs copied from the upstream taproot-assets release; they are not generated or locally designed.

Generated code — 28 files

  • every changed file under src/types/**

These TypeScript definitions are generated from the committed proto snapshots. To reproduce and verify them without updating any proto files:

yarn generate:clean
yarn generate:types
yarn generate:index
git diff --exit-code -- src/types

Do not use yarn generate for this check: it also runs the unchanged general proto updater, which targets the package baseline rather than the two selectively updated snapshots in this PR.

Added RPCs

  • Rfq.ForwardingHistory — introduced in tapd v0.8.0
  • TaprootAssetChannels.ListInvoices — introduced in tapd v0.8.1
  • TaprootAssetChannels.ListPayments — introduced in tapd v0.8.1
  • TaprootAssetChannels.SubscribeInvoices — introduced in tapd v0.8.1
  • TaprootAssetChannels.SubscribePayments — introduced in tapd v0.8.1
  • TaprootAssetChannels.TrackPayment — introduced in tapd v0.8.1

Validation

  • yarn build
  • clean type regeneration from the committed proto snapshots
  • tapd payment RPC runtime smoke test
  • verified the final proto diff contains exactly the six RPCs above
  • verified introduction versions against upstream release-tag ancestry

@bufo24 bufo24 changed the title Add RPCs from tapd v0.8.4 Add Lightning payment RPCs from tapd v0.8.4 Sep 17, 2026
@bufo24
bufo24 marked this pull request as draft September 17, 2026 09:58
@bufo24 bufo24 changed the title Add Lightning payment RPCs from tapd v0.8.4 Add tapd Lightning payment RPCs from v0.8.4 Sep 17, 2026
@bufo24 bufo24 changed the title Add tapd Lightning payment RPCs from v0.8.4 Add tapd Lightning payment RPCs through v0.8.4 Sep 17, 2026
@bufo24
bufo24 marked this pull request as ready for review September 17, 2026 10:15
@bufo24
bufo24 force-pushed the feat/tapd-v0.8.4-rpcs branch from 2b5fea2 to f9ca49b Compare September 17, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant