Repository navigation
m17: read and write the LSF CAN where the spec puts it - #11
Merged
Merged
Conversation
Spec 2.0 splits the 4-bit Channel Access Number across the LSF TYPE bytes: its top three bits are byte 0 bits 2–0, and its lowest is byte 1 bit 7. CAN() and NewLSF used byte 0 alone, so a radio on CAN 3 was read, and shown on the dashboard, as CAN 1, and NewLSF could send only even CANs. CAN 0 comes out the same either way, which kept this hidden. SetCAN sets the CAN on an existing LSF, keeping the other TYPE bits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Well, that's embarrassing, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A radio set to CAN 3 shows on the hotspot dashboard as CAN 1. With
Level = DEBUG, the journal showed:and
dashboard.logshowed:Change
CAN()reads both bytes, and the newSetCAN()writes them, keeping the other TYPE bits and updating the CRC.NewLSFusesSetCAN().streamType_tagrees. The 3.0.0 draft moves the CAN; this doesn't handle 3.0.TestLSFCANCaptureddecodes the LSF above; master reads it as 1. The other new tests cover every CAN in both modes.