Repository navigation
Security fixes - #8
Merged
Merged
Conversation
sp5wwp
commented
Oct 5, 2026
sp5wwp
commented
Contributor
- Make NewPacketFromBytes check the buffer length and return an error instead of panicking. This fixes a remote crash of m17-bridge from a single short M17P datagram, and the same crash in the gateway's reflector client and RF path.
- The exported signature of NewPacketFromBytes changes to return (Packet, error); all in-repo callers are updated.
- Stop the gateway crashing when DashboardLog is blank by making the dashboard logger a no-op when it wraps a nil slog.Logger.
- Open the gateway and bridge log files with O_APPEND instead of overwriting from the start, and drop O_SYNC to reduce SD card writes.
- Add Packet.SMSText() to trim the NUL terminator instead of always dropping the last byte.
- Add regression tests for short packets, the nil dashboard logger and SMS text handling.
- Make NewPacketFromBytes check the buffer length and return an error instead of panicking. This fixes a remote crash of m17-bridge from a single short M17P datagram, and the same crash in the gateway's reflector client and RF path. - The exported signature of NewPacketFromBytes changes to return (Packet, error); all in-repo callers are updated. - Stop the gateway crashing when DashboardLog is blank by making the dashboard logger a no-op when it wraps a nil slog.Logger. - Open the gateway and bridge log files with O_APPEND instead of overwriting from the start, and drop O_SYNC to reduce SD card writes. - Add Packet.SMSText() to trim the NUL terminator instead of always dropping the last byte. - Add regression tests for short packets, the nil dashboard logger and SMS text handling.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.