Repository navigation
Conversation
Owner
|
Thanks! Merged as ab2179a, with your two commits squashed into one under your name. I added 2c48aeb on top: the gateway postinst now gives /opt/m17 and /etc/polkit-1/rules.d back to root if an older package left them owned by UID 1001, since dpkg doesn't change the owner of a directory that already exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpkg-deb --buildkept the build machine's file owners, so installed files (the systemd unit, the polkit rule, the config sample) belonged to UID/GID 1001, the GitHub runner user. On a hotspot that ID can belong to a local account, which could then edit the service to run commands as root. Build with--root-owner-groupfor bothm17-gatewayandm17-bridge.