Conversation
When reading from OCaml strings under jsoo, handle the case when strings are represented as js strings properly. Treating them as bytes leads to a crash: "Cannot read properties of undefined (reading 'length')". Signed-off-by: Stefan Muenzel <source@s.muenzel.net>
smuenzel
force-pushed
the
fix-js-string
branch
from
September 2, 2026 11:35
b8847c2 to
35bf011
Compare
Author
|
Original commit in port of base to 5.5: public-release-reloaded@2898ada |
github-iron
added
the
forwarded-to-js-devs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading from OCaml strings under jsoo, handle the case when strings are represented as js strings properly.
Treating them as bytes leads to a crash:
"Cannot read properties of undefined (reading 'length')".