Conversation
jaredhocutt
requested changes
May 11, 2020
jaredhocutt
left a comment
Owner
There was a problem hiding this comment.
Can you add a part where it starts all of the machines and ensures that are up (e.g. that SSH is available) before running the rhsm_unsubscribe role?
The way it is currently, if a person has their cluster shutdown and they attempt to delete it, it would fail since it would be unable to connect to their cluster.
Contributor
Author
|
@jaredhocutt Will do. I'm a little behind on making this update but I'll certainly add it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed that after provision many clusters with this tool I have hundreds of nodes listed in my RHN account. Update the provisioning tool to deregister the nodes before tearing them down. Tested several times with cluster up and down to ensure the nodes are being deregistered.