feat(cli): deprecation follows a superseded Source's provenance, and forget retires it without --force - #1284
Merged
Merged
Conversation
jasonssdev
force-pushed
the
feat/1268-retire-superseded-sources
branch
from
October 3, 2026 03:25
d23229f to
4eac777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deliverable 2 of "The Quiet Engine" arc (#1268), implementing the OpenSpec change
openspec/changes/retire-superseded-sources/: deprecation follows provenance, and a superseded Source retires cleanly.provenance_orphanspredicate is folded intodeprecated_concept_ids, solistSTATUS,answerand retrieval candidates all agree through one predicate. Nothing is written to the concept file; the export input stays edge-only (the engine never reads its own export).forget <old-source> --scope sourceno longer refuses a superseded Source. In the same confirmed forget it removes the superseding Source'ssupersedesedge and detaches the old Source from surviving concepts — its generated provenance entry and its generated## Relatedbullet (shape pinned inokf.related_bullet, "source this was extracted from"). Anything else still blocks: a hand-edited bullet, or asupersedesedge from a non-Source.purgeis unchanged.relate supersedesno longer prints "not a seeded relation type".docs/cli.mdupdated.Spec deviation (applied to the
forget-commanddelta and design D5): the generated## Relatedbullet is pinned to the single phrase the builder and attach write, so a differently worded bullet counts as hand-written and still blocks.Related issue
Closes #1259
Closes #1263
Refs #1268
Type of change
feat— new featurefix— bug fixdocs— documentation onlyrefactor— no behavior changetest— tests onlychore/ci— tooling, build, or CIHow was this tested?
forget sources/v1 --scope source --autoexited 1 on thesupersedesedge and the inbound link (bug: retiring a superseded Source dead-ends — supersedes warns "not seeded" and forget needs --force, leaving a dangling reference #1263) and now exits 0; a sole-source concept of a superseded Source stayedstableindeprecated_concept_ids,listandanswer(bug: editing a watched source writes -N copies of every derived concept, and supersedes leaves its sole-source concepts stable #1259) and is now deprecated at read time with its bytes unchanged;lintreports no dangling reference after the forget.sources/root filter, the live-Source subset test, the generated-bullet matcher, the Source-authored superseder check, the rescan guard, and purge taking the retire path.ruff check,ruff format --check,mypy .(533 files),evals/run_self_tests.py, andpytest --cov(9639 passed, 2 skipped, 96.47%) pass.Checklist
ruff,mypy,pytest).