Repository navigation
Conversation
….20.0 pin The explicit PackageReference sat below the 1.24.0 that OKF4net.Agents requires (NU1605). The version now flows from the OKF4net.Agents ProjectReference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The existing project reference supplies the required dependency transitively, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Fixes the acme-retail-agent sample’s dependency downgrade error after the library update in #190.
Changes:
- Removes the stale
Microsoft.Agents.AIpin so the sample inherits the library’s dependency transitively. - Documents the fix under Unreleased.
| File | Description |
|---|---|
| samples/acme-retail-agent/src/AcmeRetailAgent/AcmeRetailAgent.csproj | Removes the redundant package reference. |
| CHANGELOG.md | Records the sample build fix. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
samples/acme-retail-agentdoes not build ondev:Cause
src/OKF4net.Agentswas bumped toMicrosoft.Agents.AI1.24.0 (#190); the sample kept its own explicit pin at 1.20.0. Samples have their own solutions and are outsideOKF4net.sln/CI, so nothing caught it.Fix
Removed the redundant explicit
Microsoft.Agents.AIPackageReferencefrom the sample's csproj. The sample referencesOKF4net.AgentsbyProjectReference, so the package (and theMicrosoft.Agents.AInamespace used inProgram.cs) flows transitively at the version the library requires, with no second pin to keep in sync.Microsoft.Extensions.AI.OpenAIstays (the sample usesOpenAItypes directly). Added a### Fixedentry under[Unreleased](earlier sample fixes are listed there).Built (
dotnet build, 0 warnings, 0 errors)OKF4net.sln: 0 warnings, 0 errors;dotnet format --verify-no-changesclean🤖 Generated with Claude Code