fix: reorder None to the end of type unions (RUF036) - #669
Closed
syzayd wants to merge 0 commit into
Closed
Conversation
jd
force-pushed
the
fix/ruf036-none-union-order
branch
from
August 5, 2026 07:27
d6184fa to
ac30991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ruffisn't version-pinned inpyproject.toml, and a newer release started enforcingRUF036("Nonenot at the end of a type union"). That currently flags 14 pre-existing annotations acrosstenacity/__init__.py,tenacity/asyncio/__init__.py, andtenacity/retry.py, and breaks thelintCI job for any PR againstmainright now (verified: the last green run onmain, 2026-08-01, predates this).Split out on its own here (was flagged as noise when bundled into #668) so it can be reviewed independently.
Change
Pure reordering, no behavior change:
uv run ruff check --fix --unsafe-fixes .thenruff format ..Verification