Repository navigation
refactor: fold css-compare into html-compare - #691
Merged
Merged
Conversation
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jeremie Drouet <jeremie.drouet@gmail.com>
Contributor
|
📈 This is how your metrics evolved 📉 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css-comparewas a separate published crate whose only consumer anywhere ishtml-compare, which is itself only a dev-dependency of mrml's test suite. crates.io shows no external reverse dependencies. A whole crate — Cargo.toml, CHANGELOG, LICENSE, a workspace member entry, two Dockerfile lines and a release surface — to hold 407 lines that one sibling calls twice.It becomes a private
mod css;inside html-compare. The source moves verbatim: git records it as a 100% rename, and the two call sites just repoint tocrate::css::{compare, Error}.lightningcssmoves onto html-compare's manifest with the same version requirement anddefault-features = false; both before and after resolve lightningcss 1.0.0-alpha.71 with no features enabled by anything else.Already-published
css-compareversions stay on crates.io and keep working. The name simply stops receiving releases.Its two tests came along and now run as
css::tests::*— html-compare goes from 14 to 16. mrml-core stays at 621. fmt, check and clippy clean under-Dwarnings.Second commit fixes the repository layout in contributing.md, which still listed the crate.