Skip to content

fix(ci): commit fixture lockfiles after set-version - #1208

Merged
jdx merged 1 commit into
mainfrom
cursor/fix-release-fixture-lock-db1f
Aug 22, 2026
Merged

fix(ci): commit fixture lockfiles after set-version#1208
jdx merged 1 commit into
mainfrom
cursor/fix-release-fixture-lock-db1f

Conversation

@jdx

@jdx jdx commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

#795 still fails test after the MSRV lockfile fix. Job 96966142310 dies on the dirty-tree gate because usage-rs/tests/fixtures/runtime-identity/Cargo.lock is rewritten from 5.1.0 to 6.0.0 for usage-argv / usage-derive / usage-rs.

That fixture path-depends on usage-rs. Tests run cargo run --manifest-path against it, which updates the nested lock after set-version. tasks/release-plz never committed that lockfile.

Change

After the workspace cargo update, regenerate every tracked fixture Cargo.lock with cargo generate-lockfile and git add them.

Validation

A local set-version 6.0.0 plus cargo generate-lockfile on the fixture produced the same three-line version bump CI reported. git add usage-rs/tests/fixtures/*/Cargo.lock stages that file (it is tracked despite fixtures/.gitignore).

After merge, the next release-plz run should force-push a release commit whose fixture lock already matches 6.0.0.

Open in Web Open in Cursor 

The runtime-identity fixture pins path deps on usage-rs. After a release
bump, cargo run in that crate rewrites its lock from 5.1.0 to 6.0.0 and
the test job's dirty-tree gate fails. Regenerate tracked fixture locks
and git add them with the rest of the release commit.

Co-authored-by: jdx <jdx@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jdx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e1ef0b41-8762-4c5a-868f-a184531c5fa6

📥 Commits

Reviewing files that changed from the base of the PR and between b0e0795 and 7b0d859.

📒 Files selected for processing (1)
  • tasks/release-plz

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx marked this pull request as ready for review August 22, 2026 02:48
@jdx
jdx enabled auto-merge (squash) August 22, 2026 02:48
@github-actions

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
markdown ▁▁▁▁▅▅█████████ 270,571,795 → 270,640,701 +0.03% 23.46 → 23.23ms -0.96%
startup ▁▁▁▁▃▃▆▆▆▆█████ 868,282 → 868,309 +0.00% 0.93 → 0.88ms -4.89%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

Shadow comparison

Parsing mise use -g node@20 against a shadow of mise's committed spec.
Reported, not gated: the shadow grows as the derive learns to express more, so
what to watch is the ratio rather than either column.

framework instructions, cold parse vs usage
usage 8425
argh 6307 0.7x
clap 6316072 749x
bpaf 21909147 2600x
                                              min       p01       p10    median
usage-rs: argv -> struct                      416       429       435       445  ns
argh: argv -> struct                          285       293       298       304  ns
clap: build tree + parse -> struct         518605    519665    521711    524764  ns
bpaf: build parser + parse -> struct      1548353   1548353   1561748   1586636  ns

usage: argv -> struct                             456 ns      0.46 µs
clap: build tree + parse -> struct             525918 ns    525.92 µs
clap: parse -> struct, tree reused              22549 ns     22.55 µs
clap: build tree only                          329478 ns    329.48 µs

7b0d859b3816 vs b0e079525ed4 · measured on the runner, not pushed to the history.

@jdx
jdx merged commit 31263df into main Aug 22, 2026
10 checks passed
@jdx
jdx deleted the cursor/fix-release-fixture-lock-db1f branch August 22, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants