fix(ci): commit fixture lockfiles after set-version - #1208
Conversation
The runtime-identity fixture pins path deps on usage-rs. After a release bump, cargo run in that crate rewrites its lock from 5.1.0 to 6.0.0 and the test job's dirty-tree gate fails. Regenerate tracked fixture locks and git add them with the rest of the release commit. Co-authored-by: jdx <jdx@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 24 minutes Limit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
Summary
#795 still fails
testafter the MSRV lockfile fix. Job 96966142310 dies on the dirty-tree gate becauseusage-rs/tests/fixtures/runtime-identity/Cargo.lockis rewritten from5.1.0to6.0.0forusage-argv/usage-derive/usage-rs.That fixture path-depends on
usage-rs. Tests runcargo run --manifest-pathagainst it, which updates the nested lock afterset-version.tasks/release-plznever committed that lockfile.Change
After the workspace
cargo update, regenerate every tracked fixtureCargo.lockwithcargo generate-lockfileandgit addthem.Validation
A local
set-version 6.0.0pluscargo generate-lockfileon the fixture produced the same three-line version bump CI reported.git add usage-rs/tests/fixtures/*/Cargo.lockstages that file (it is tracked despitefixtures/.gitignore).After merge, the next
release-plzrun should force-push a release commit whose fixture lock already matches 6.0.0.