Skip to content

update usage of deprecated str downcase thingy in nushell #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 4 commits into from
Aug 24, 2026
Merged

update usage of deprecated str downcase thingy in nushell #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d33b065
fix deprecated nushell code in go lib
TheBearodactyl Aug 23, 2026
6331b40
update deprecated nushell completion code
TheBearodactyl Aug 23, 2026
5ffe52f
Merge branch 'jdx:main' into main
TheBearodactyl Aug 23, 2026
a515ba5
Merge branch 'main' into main
TheBearodactyl Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions argv/src/script.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,10 +454,10 @@ def --env __usage_complete_{ident} [spans: list<string>] {{
let commands = (if $wants_commands {{
let prefix = ($spans | last)
let insensitive = $nu.os-info.name == "windows"
let match_prefix = if $insensitive {{ $prefix | str downcase }} else {{ $prefix }}
let match_prefix = if $insensitive {{ $prefix | str lowercase }} else {{ $prefix }}
which
| where {{|row|
let candidate = if $insensitive {{ $row.command | str downcase }} else {{ $row.command }}
let candidate = if $insensitive {{ $row.command | str lowercase }} else {{ $row.command }}
$candidate | str starts-with $match_prefix
}}
| each {{|row| {{ value: $row.command, description: $row.path }} }}
Expand Down
4 changes: 2 additions & 2 deletions go/argv/script.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,10 +324,10 @@ def --env __usage_complete_{ident} [spans: list<string>] {
let commands = (if $wants_commands {
let prefix = ($spans | last)
let insensitive = $nu.os-info.name == "windows"
let match_prefix = if $insensitive { $prefix | str downcase } else { $prefix }
let match_prefix = if $insensitive { $prefix | str lowercase } else { $prefix }
which
| where {|row|
let candidate = if $insensitive { $row.command | str downcase } else { $row.command }
let candidate = if $insensitive { $row.command | str lowercase } else { $row.command }
$candidate | str starts-with $match_prefix
}
| each {|row| { value: $row.command, description: $row.path } }
Expand Down