Skip to content

fix: resolve symlinks for pnpm windows bundle - #192

Closed
bestickley wants to merge 1 commit into
mainfrom
fix-pnpm-windows-2
Closed

bestickley wants to merge 1 commit into
mainfrom
fix-pnpm-windows-2

Conversation

@bestickley

@bestickley bestickley commented Dec 28, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #183.

Key comment from code:

// Compress-Archive doesn't support resolving symlinks like `zip` command
// does with -y option. Therefore, we need to resolve symlinks then compress.

@bestickley
bestickley requested a review from revmischa December 28, 2023 15:32
@bestickley bestickley changed the title fix: remove symlinks for pnpm windows bundle fix: resolve symlinks for pnpm windows bundle Dec 28, 2023
@revmischa

Copy link
Copy Markdown
Member

Cool! Please resolve conflicts

@revmischa

Copy link
Copy Markdown
Member

Rebased onto main as #278 (same fix, with the temp dir moved next to the symlink so renameSync doesn't fail across drives). Thanks Ben.

@revmischa

Copy link
Copy Markdown
Member

Superseded by #278, released in v4.3.5.

@revmischa revmischa closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Usage with PNPM on Windows

2 participants