fix(launcher): recover search errors and expose queued index work - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes second-review findings C and D, following merged watcher (#18) and automatic privacy cleanup (#19) fixes. Separate implementation commits are retained.
queued,scanning,idle,disabled, orfailed. Pending work remains queued throughout cooldown/settling; changed roots do not look like a finished empty scan. Preserve generation cancellation, bounded/coalesced work, publication lock order, and the resource/rest policy.Verification and reviews
9e6d80c72153e622867f0484138320e426fffb7band current-base heade464cdd6b8f677565e2cdf947a0f6b1c249cd35dhave the identical reviewed tree6ff4930cb4238b9f187de76cc88d8132808971ce.54df7427-982a-4d2and7ed4808f-a2d2-421, including focused browser checks.21d859bb-d94f-454found a late-disable watcher-disposal gap;a7d933c0-6c2e-475approved the initial source. The gap is repaired: rejected begin reconciles actual watcher ownership before relabeling a generation, accounting disposal and preserving rest.obsolete watcher retained after late begin rejectionwithout hanging; repaired code passes. A test-hook type-alias repair preserves Clippy's unchanged strict lint gate.bd0bf756-cde2-4b9,290ce8bc-8dd1-4b7. All reviews are subagent reviews, not human GitHub approvals.Final current-base protected CI 36402498211 passed, including all three platform builds/tests, all 233 browser tests, installed Windows/Linux native journeys, and Required checks. The late-disable regression passed on all three OSes. Verification-tools run
36402497297also passed.Both native records have clean, unchanged, matching build/test source
21fa06ea2b0070d3740098585e0606d69869ef74, with reviewed tree6ff4930cb4238b9f187de76cc88d8132808971ce. Both record 28 passed native journeys, complete cleanup, and 100 retained schema-2 timing samples (25/scenario). Windows additionally covers upstream-clear cleanup through SQLite contention; Linux does not implement that heuristic.a0523559e76441b8de0effa2ec1ff087d9e77fa8e226ff9c503dda5fdcd1febf.826d3d4e08b1e9272f38d2085ab4c3179daf7c43c84cc464bf24966d9b385033.browser/launcher-file-refresh-dist-7506d--and-finished-empty-results/files-queued.pngandbrowser/launcher-file-status-follo-e6ecc-owing-a-finished-empty-scan/files-disabled.png. Downloaded and inspected; focused successful traces are also retained locally.Branch protection was rechecked unchanged: strict app-bound Required checks, administrator enforcement, PR/conversation requirements, no force push/deletion. No bypass.
Browser tests mock IPC. Controlled worker clocks do not measure OS scheduling/disposal latency. No controlled macOS/Wayland native, physical-paint, historical installed-version upgrade, or universal performance claim. No production release.