Unify TypeID validation boundaries and API contracts - #1
Merged
Merged
Conversation
Route all caller-invalid data through ValidationException, preserve value-object invariants during unserialization, and make raw bytes the Base32 conversion core.
Restore the Base32 bit-layout map (needed to maintain the unrolled encoder), assert unpack failures, and give mute Pest datasets named keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidationException(InvalidArgumentException), includingfromString.ConstructorExceptionis reserved for UUID generation failures.Base32::encodeBytes/decodeBytes(no ramsey round-trip). RemovedhasSuffix()and deadisValidUuidv7. Exception messages truncate and escape rejected values. Added K-sortable generate coverage.Test plan
composer test(127 tests, 6203 assertions)vendor/bin/pint --testConstructorExceptionon parse paths update toValidationException/InvalidArgumentException