Repository navigation
Keep a call racing with close() from using a freed PeerConnection (1.0.4-ip.2) - #4
Merged
Merged
Conversation
…0.4-ip.2) close() now releases the native PeerConnection, so a call on another thread that read the handle just before could use it after it was freed: an ICE candidate arriving while a connection is dropped, for example. Every call now takes its own reference under the Java object's monitor, and close() empties the handle under that same monitor before dropping Java's reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close() now really frees the native PeerConnection, so a call on another thread that read the handle just before (an ICE candidate arriving while the connection is dropped) could use freed memory and take the whole JVM down.
Every JNI call now takes its own reference under the Java object's monitor, and close() empties the handle under that monitor before dropping Java's reference. The monitor is only held to read the handle, never across a call into WebRTC.
Not compiled locally: the Build check on this pull request is the compile test.
🤖 Generated with Claude Code