Skip to content

ADR-391: Rename design-first-draft reference to detailed-design-first-draft in design-deliverable-breakdown/SKILL.md - #242

Open
jodavis-claude wants to merge 1 commit into
dev/claude/ADR-389from
dev/claude/ADR-391
Open

ADR-391: Rename design-first-draft reference to detailed-design-first-draft in design-deliverable-breakdown/SKILL.md#242
jodavis-claude wants to merge 1 commit into
dev/claude/ADR-389from
dev/claude/ADR-391

Conversation

@jodavis-claude

Copy link
Copy Markdown
Collaborator

Reword 'design doc' to 'Detailed Design doc' in the frontmatter description, use-this-skill-when bullet, and both steps, matching detailed-design-first-draft/SKILL.md's established phrasing.


Stack created with GitHub Stacks CLIGive Feedback 💬

@jodavis-claude jodavis-claude left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against ADR-391's exit criteria and CONTRIBUTING.md.

The diff is a tight, well-scoped wording pass on plugins/dev-team/skills/design-deliverable-breakdown/SKILL.md: frontmatter description:, the "Use this skill when" bullet, and both step bodies now say "Detailed Design doc" instead of "design doc", and the stale design-first-draft reference in step 1 is renamed to detailed-design-first-draft. I confirmed:

  • No remaining references to the old design-first-draft skill name or to write-design-spec anywhere in the file.
  • The new step-1 wording ("the placeholder left by detailed-design-first-draft") is accurate — verified against detailed-design-first-draft/SKILL.md (step 3) and its assets/detailed_design_template.md, which does leave a ## Deliverables placeholder comment naming design-deliverable-breakdown.
  • Phrasing matches the established "Detailed Design document"/"Detailed Design doc" style used in detailed-design-first-draft/SKILL.md.
  • argument-hint and the _design_*.md file reference are correctly left unchanged, consistent with the spec's decision that the Detailed Design doc keeps the old _design_<Feature>.md naming.
  • Change is scoped to only the file named in the exit criteria; commands/write-design-spec.md (out of scope per the brief, owned by ADR-392) and design-create-work-items/SKILL.md (a separate, unlisted stale reference the brief already flagged as an open question for the spec owner, not this task) were correctly left untouched.
  • The exit criteria's literal "Validate" step (run against Task 2's ADR-380 Detailed Design doc) could not be executed because no ADR-380 artifact exists anywhere in this repository — this is a pre-existing gap in the task's validation instructions, not a defect in this diff, and is already documented in the context file's Known Ambiguities for the spec/task owner to follow up on.

No Priority 1-5 issues found. Approving.

@jodavis-claude jodavis-claude left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off review for ADR-391.

Prior review (submitted 2026-09-04T00:21:21Z) approved this PR with no inline comments and no
Priority 1-5 issues. No commits have been added since that review (HEAD is still
a046c8a, the exact commit the prior review evaluated), so there
were no threads to resolve and no new files to scan.

Re-verified independently:

  • grep -n "design-first-draft\|write-design-spec" against
    plugins/dev-team/skills/design-deliverable-breakdown/SKILL.md matches only the intended
    detailed-design-first-draft reference — satisfies the exit criterion.
  • Full file re-read confirms internal consistency: frontmatter description, "Use this skill
    when" bullet, and both step bodies consistently say "Detailed Design doc"; argument-hint and
    the _design_*.md filename reference are correctly left unchanged.
  • Scope is unchanged and correct: commands/write-design-spec.md and
    design-create-work-items/SKILL.md remain untouched, consistent with the task brief's documented
    scope boundaries.
  • No Priority 1-5 issues found.

No prior threads existed to resolve (prior review had zero inline comments). Signing off.

…-draft in design-deliverable-breakdown/SKILL.md

Reword 'design doc' to 'Detailed Design doc' in the frontmatter description, use-this-skill-when bullet, and both steps, matching detailed-design-first-draft/SKILL.md's established phrasing.
@github-actions

Copy link
Copy Markdown

build-and-test: Python test results

Status: ✅ Passed

Test log

@jodavis-claude
jodavis-claude marked this pull request as ready for review September 10, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants