Skip to content

Telemetry: count each sync backend once per app load #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonocodes merged 1 commit into from
Sep 19, 2026
Merged

Telemetry: count each sync backend once per app load #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/TELEMETRY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ This is everything Savr ever sends:
| `pwa-install-dismissed` | The user dismisses the PWA install prompt (Chromium only) |
| `sync-connect-dropbox` | Cloud sync is connected to Dropbox |
| `sync-connect-googledrive` | Cloud sync is connected to Google Drive |
| `sync-connect-remotestorage` | Cloud sync is connected to a remoteStorage provider (user@host account) |

## What is never collected

Expand Down
13 changes: 12 additions & 1 deletion src/utils/sync/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,13 @@ function initRemote() {
// articles (e.g. from the bookmarklet flow) whose uploads haven't reached the server yet.
let hasTriggeredInitialReconcile = false;

// Providers already reported to telemetry this app load. RS re-emits
// "connected" for an already-connected backend during startup (and can emit
// it more than once), so without this a single app load would log several
// sync-connect events and inflate the backend totals. One event per
// provider per page load; a different provider connecting later still counts.
const trackedSyncProviders = new Set<string>();

// Apply a single reconciler Op (progress is tracked by the caller).
async function applyOp(op: Op): Promise<void> {
if (op.type === "fetch") {
Expand Down Expand Up @@ -335,7 +342,11 @@ function initRemote() {
console.info(`🟢 remoteStorage connected to "${remoteStorage.remote.userAddress}"`);
// Anonymous telemetry: record which provider type connected, never the
// account address. `backend` is "dropbox" | "googledrive" | "remotestorage".
trackSyncConnect((remoteStorage as unknown as { backend?: string }).backend || "unknown");
const provider = (remoteStorage as unknown as { backend?: string }).backend || "unknown";
if (!trackedSyncProviders.has(provider)) {
trackedSyncProviders.add(provider);
trackSyncConnect(provider);
}
hasTriggeredInitialReconcile = false;
// Reconcile is intentionally NOT triggered here. Running it immediately on "connected"
// is unsafe: RS's local listing cache hasn't been refreshed from the server yet, so
Expand Down
Loading