Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #181 without raising jsonpath's Ruby requirement or forcing older Ruby users onto multi_json 1.21 (which requires Ruby >= 3.2).
MultiJSON.parsewhen the modern constant exists. This avoids both the deprecatedMultiJsonconstant and the deprecateddecode/loadmethods introduced in multi_json 1.21. Merely replacingdecodewithloadwould still warn on current releases.MultiJson.loadAPI. Declare its minimum multi_json version (1.3) in the gemspec.max_nesting.Validation
Ruby 4.0.7, upstream's declared minitest 2.2.2:
Each: 119 tests, 187 assertions, 0 failures, 0 errors, 2 existing skips. These are the core
test/test_jsonpath.rbtests, not a claim that the entire Rake/CLI suite or older Ruby matrix was run. Before the implementation change, the new warning regression failed with both the deprecated constant anddecodewarnings.Also verified the downstream k8s-ruby 0.18.0
K8s::Transport.token_from_auth_providercommand-output/token-key path with a local/usr/bin/printffixture, no cluster/network access: same extracted token before/after; both warnings before, no warnings after. Explicit-token client initialization does not invoke JsonPath.Scope
Draft for maintainer review. No consumer fork dependency, monkeypatch, warning suppression, Ruby requirement change, or unrelated dependency upgrade. A released jsonpath fix is needed before downstream applications can consume this through a normal gem update.