Repository navigation
build(deps): update rusqlite to 0.40 - #421
Merged
Merged
Conversation
rusqlite 0.38 put the u64 conversions behind the fallible_uint feature; enabling it keeps the three reads of counts and sizes as they were: an i64 converted with a range check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rusqlite0.37 → 0.40 incore. Since 0.38u64: FromSqlis behind thefallible_uintfeature; it is enabled, sobackup.rs,store.rsandsync/mod.rsread counts and sizes as before (ani64converted with a range check).web/Cargo.lockfollows throughlists-core. Supersedes #414.Checked locally:
make lint,make denyandmake test(479 passed) pass. The Android and macOS builds are left to CI.Closes #418