Repository navigation
macOS: leave clicks, selection and drags of the lists to AppKit (#424) - #425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task list and the sidebar of macOS leave clicks, selection, menus and drags to AppKit where no product decision needs our own behaviour.
What changes
doubleAction.NSTableView.menu(for:), so the table outlines the row while the menu is open. ⌃click is no longer handled by hand in the table and in a subtask line.mouseUp).Space, ⌫ and Return of the list stay as they are (as in Things and Mail), by the decision recorded in #424.
Checks
make apple,make apple-lint,make apple-test(newReorderTests).Not checked, since they need the mouse on a visible window: selection on press, double click, the menu and its outline on right click and ⌃click (also in a subtask line), dragging several tasks between rows, the events block and the clipboard note, the look of the sidebar, Esc in a popover.
Closes #424