Repository navigation
Remove the notification row from Settings - #39
Merged
Merged
Conversation
The row stored nothing: it mirrored the system notification state and repeated the permission request. The app still asks once on first launch; after that the answer is changed in the system settings. Closes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
What
Settings no longer has the Notifications group. The "Sync problem alerts" row stored nothing: it showed whether Android lets the app post notifications and repeated the permission request through a Turn on button.
NotificationAccess.of,SyncNotifier.access,SyncNotifier.settingsIntent.Checks
assembleDebug lintDebug testDebugUnitTest connectedDebugAndroidTeston the API 36 emulator: build and lint pass, 73 instrumented tests pass.