Repository navigation
Readable sync errors and a save reminder after Test Connection - #42
Merged
Merged
Conversation
HTTP errors no longer carry the raw JSON body: the first line names the error and the body follows as text. The notification for a persistent problem now says what to change in Settings instead of repeating the server response. Test Connection checks the typed token without saving it, so a passed test followed by Sync now kept failing with the saved token. Settings now asks to save after a successful test of unsaved values. Closes #41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41
What
linkding rejected the API token (HTTP 401),linkding API not found (HTTP 404), otherwiselinkding returned HTTP <code>). A JSON body follows as text:detailas is, field errors asfield: message. Plain text is kept; an empty body shows only the first line. This text is used on the queue card and in the Test Connection result.Checks
assembleDebug lintDebug testDebugUnitTest connectedDebugAndroidTeston the API 36 emulator: build and lint pass, 74 instrumented tests pass.ApiErrorsTest,QueueUiTest.testedButUnsavedTokenAsksToSaveSettings;SyncNotifierTest.workerNotifiesRejectedTokenAndClearsAfterSuccessnow checks the notification text and the queue card error.