vim-plug requires +iconv but doesn't work with +iconv/dyn

[DervishD]

Latest vim-plug version require +iconv to run shell commands on Windows, but doesn't work when +iconv/dyn is available. That didn't happen in the previous version.

This was introduced in #913 and I think it's a good idea, except that for some reason at least in my system, has(iconv) returns 0 even though I have +iconv/dyn and the iconv() function works perfectly within Vim.

Maybe it's something I did wrong in my system, I really don't know, but if I can't fix this I can't use vim-plug and I depend on it somewhat.

Thanks in advance and feel free to ask me for additional information.

---

VIM - Vi IMproved 8.1 (2018 May 18, compiled Nov  1 2019 01:01:21)
MS-Windows 64-bit GUI version
Included patches: 1-2237
Compiled by stop_@LAPTOP-E7OHISR4
Huge version with GUI.  Features included (+) or not (-):
+acl                +clipboard          +directx            +gettext/dyn        +localmap           +packages           +scrollbind         -termguicolors      +visual
+arabic             +cmdline_compl      -dnd                -hangul_input       +lua/dyn            +path_extra         +signs              +terminal           +visualextra
+autocmd            +cmdline_hist       -ebcdic             +iconv/dyn          +menu               +perl/dyn           +smartindent        -termresponse       +viminfo
+autochdir          +cmdline_info       +emacs_tags         +insert_expand      +mksession          +persistent_undo    +sound              +textobjects        +vreplace
+autoservername     +comments           +eval               +job                +modify_fname       -postscript         +spell              +textprop           -vtp
+balloon_eval       +conceal            +ex_extra           +jumplist           +mouse              +printer            +startuptime        -tgetent            +wildignore
-balloon_eval_term  +cryptv             +extra_search       +keymap             +mouseshape         +profile            +statusline         +timers             +wildmenu
+browse             +cscope             -farsi              +lambda             +multi_byte_ime/dyn +python/dyn         -sun_workshop       +title              +windows
++builtin_terms     +cursorbind         +file_in_path       +langmap            +multi_lang         +python3/dyn        +syntax             +toolbar            +writebackup
+byte_offset        +cursorshape        +find_in_path       +libcall            +mzscheme/dyn       +quickfix           +tag_binary         +user_commands      -xfontset
+channel            +dialog_con_gui     +float              +linebreak          +netbeans_intg      +reltime            -tag_old_static     +vartabs            -xim
+cindent            +diff               +folding            +lispindent         +num64              +rightleft          -tag_any_white      +vertsplit          +xpm_w32
+clientserver       +digraphs           -footer             +listcmds           -ole                +ruby/dyn           +tcl/dyn            +virtualedit        -xterm_save
   system vimrc file: "$VIM\vimrc"
     user vimrc file: "$HOME\_vimrc"
 2nd user vimrc file: "$HOME\vimfiles\vimrc"
 3rd user vimrc file: "$VIM\_vimrc"
      user exrc file: "$HOME\_exrc"
  2nd user exrc file: "$VIM\_exrc"
  system gvimrc file: "$VIM\gvimrc"
    user gvimrc file: "$HOME\_gvimrc"
2nd user gvimrc file: "$HOME\vimfiles\gvimrc"
3rd user gvimrc file: "$VIM\_gvimrc"
       defaults file: "$VIMRUNTIME\defaults.vim"
    system menu file: "$VIMRUNTIME\menu.vim"
Compilation: cl -c /W3 /nologo  -I. -Iproto -DHAVE_PATHDEF -DWIN32  -DFEAT_CSCOPE -DFEAT_TERMINAL -DFEAT_SOUND -DFEAT_NETBEANS_INTG -DFEAT_JOB_CHANNEL   -DFEAT_XPM_W32   -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 /MP -DHAVE_STDINT_H /Ox /GL -DNDEBUG  /MD -DFEAT_MBYTE_IME -DDYNAMIC_IME -DGLOBAL_IME -DFEAT_GUI_MSWIN -DFEAT_DIRECTX -DDYNAMIC_DIRECTX -DFEAT_DIRECTX_COLOR_EMOJI -DDYNAMIC_ICONV -DDYNAMIC_GETTEXT -DFEAT_TCL -DDYNAMIC_TCL -DDYNAMIC_TCL_DLL=\"tcl86.dll\" -DDYNAMIC_TCL_VER=\"8.6\" -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL=\"lua53.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL=\"python38.dll\" -DFEAT_MZSCHEME -I "..\..\..\libs\racket-7.4\include" -DDYNAMIC_MZSCHEME -DDYNAMIC_MZSCH_DLL=\"libracketxxxxxxx.dll\" -DDYNAMIC_MZGC_DLL=\"libmzgcxxxxxxx.dll\" -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl530.dll\" -DFEAT_RUBY -DDYNAMIC_RUBY -DDYNAMIC_RUBY_VER=26 -DDYNAMIC_RUBY_DLL=\"x64-msvcrt-ruby260.dll\" -DFEAT_HUGE /Fd.\ObjGXULYHTRZVAMD64/ /Zi
Linking: link  /nologo /opt:ref /LTCG:STATUS /d2:-AllowCompatibleILVersions /HIGHENTROPYVA:NO oldnames.lib kernel32.lib advapi32.lib shell32.lib gdi32.lib  comdlg32.lib ole32.lib netapi32.lib uuid.lib /machine:AMD64 gdi32.lib version.lib   winspool.lib comctl32.lib advapi32.lib shell32.lib netapi32.lib  /machine:AMD64  msvcrt.lib  user32.lib  /nodefaultlib:lua53.lib  /STACK:8388608  /nodefaultlib:python27.lib /nodefaultlib:python38.lib   "..\..\..\libs\IronTcl\x64\lib\tclstub86.lib" winmm.lib WSock32.lib .\xpm\x64\lib-vc14\libXpm.lib /PDB:gvim.pdb -debug

• Type:
  • [x ] Bug
  • Enhancement
  • Feature Request
  • Question
• OS:
  • All/Other
  • Linux
  • OS X
  • [ x] Windows
• Vim:
  • Terminal Vim
  • [ x] GVim
  • Neovim

[janlazo]

I missed that feature in :h version. I will fix it ASAP.

[DervishD]

Just to make sure everybody following the bug report is informed: there's no has('iconv/dyn') test in Vim (well, it will always return 0), and the problem was entirely mine, my Vim was not loading libiconv for some reason I've yet not discovered.