fix(release): avoid SIGPIPE in tag-release changelog generation - #121
Merged
Merged
Conversation
git log piped to `head` under `set -o pipefail` aborts the script with exit 141 when the commit range exceeds the head limit. This bit the v1.11.0 release (156 commits since v1.10.1): tag-release.sh died before tagging. Use `git log -n 30` instead of `| head -30`, and make the tap script's cosmetic grep|head display line non-fatal with `|| true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make tag(viascripts/tag-release.sh) aborts with exit 141 (SIGPIPE) when the commit range since the previous tag exceeds 30 commits. Underset -o pipefail, this line:CHANGELOG=$(git log "${PREV}..HEAD" --oneline | head -30)makes
git logreceive SIGPIPE whenhead -30closes the pipe early, and pipefail propagates 141, killing the script before any tag is created.This bit the v1.11.0 release — 156 commits since v1.10.1. (Worked around at release time by running with the fix in the working tree; this PR persists it.)
Fix
tag-release.sh: usegit log -n 30(no pipe, no SIGPIPE).update-homebrew-tap.sh: make the cosmeticgrep | head -4display line non-fatal with|| true(same latent class of bug; harmless but defensive).No functional change to release output.