Skip to content

Updates for TRX-DUO and the Red Pitaya using Protocol 2. - #16

Merged
k3it merged 4 commits into
k3it:masterfrom
n1gp:master
Aug 5, 2026
Merged

k3it merged 4 commits into
k3it:masterfrom
n1gp:master

Conversation

@n1gp

@n1gp n1gp commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@k3it

k3it commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Rick, Thank you for the pull request. This looks clean to me and I do not see anything that could break the existing hw.

A couple of issues flagged by Claude pull review but these look really minor to me:

  • FeedWDT sends an all-zero general-registers packet with a static
    sequence number.
    It works for feeding the watchdog on the boards you
    tested, but since it's the general endpoint it also re-writes general config
    (e.g. the Alex-enable byte 0x03 set in StartCapture2) to zero every
    500ms. Harmless on RP/TRX-DUO, and evidently fine on the ANAN boards -
    just flagging it in case a future P2 device relies on that state.
    No change needed now.

  • long int start_time could be DWORD to match the rest of the file's tick handling,
    and the (char*)HERMESLT cast is redundant since other comparisons use the bare
    devname == HERMES form.

I'm not sure if P1 is still runs on the most of deployed skimmers (I've been out of the loop lately). Are you able to test a non-HL2 P1 radio (e.g. a plain Hermes) still discovers/starts/streams normally with these changes? You mentioned ANAN P2 and the HL2. I just wanted to make sure sure a standard P1 board isn't affected (it does not look like it would be based the changes).

I'm ok with v143 to v145 bump.

@n1gp

n1gp commented Aug 5, 2026 via email

Copy link
Copy Markdown
Contributor Author

@n1gp

n1gp commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Latest changes tested OK w/ RP - P2 and HL - P1

@k3it

k3it commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Looking good Rick. Thank you. Merging and will do a build and publish the new ver in a bit.. 73!

@k3it
k3it merged commit d9fea8e into k3it:master Aug 5, 2026
1 check passed
n1gp pushed a commit to n1gp/HermesIntf that referenced this pull request Sep 4, 2026
- Bump version to 26.8.9 in hermes.rc (FILEVERSION/PRODUCTVERSION + strings)
- Add 26.8.9 changelog entry to readme.txt for PR k3it#16 (TRX-DUO/Red Pitaya
  Protocol 2 fixes, P2 watchdog feed) and PR k3it#17 (fix MAC address DLL filter)
- msbuild.yml: upload built HermesIntf.dll as a workflow artifact and
  auto-attach it to published GitHub releases

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SsVwSNXUxxufvxfb63DbT4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants