Repository navigation
Updates for TRX-DUO and the Red Pitaya using Protocol 2. - #16
Conversation
|
Rick, Thank you for the pull request. This looks clean to me and I do not see anything that could break the existing hw. A couple of issues flagged by Claude pull review but these look really minor to me:
I'm not sure if P1 is still runs on the most of deployed skimmers (I've been out of the loop lately). Are you able to test a non-HL2 P1 radio (e.g. a plain Hermes) still discovers/starts/streams normally with these changes? You mentioned ANAN P2 and the HL2. I just wanted to make sure sure a standard P1 board isn't affected (it does not look like it would be based the changes). I'm ok with v143 to v145 bump. |
|
I fired up my Hermes and flashed P1 to it. Skim Svr w/ these changes
discovers/starts/streams normally.
But the issues Claude found, I'd like to address those and get back to you
with some corrections...
…________________________________
From: Vasiliy Gokoyev ***@***.***>
Sent: Tuesday, August 4, 2026 10:57 PM
To: k3it/HermesIntf ***@***.***>
Cc: Rick Koch ***@***.***>; Author ***@***.***>
Subject: Re: [k3it/HermesIntf] Updates for TRX-DUO and the Red Pitaya using Protocol 2. (PR #16)
[https://avatars.githubusercontent.com/u/9923389?s=20&v=4]k3it left a comment (k3it/HermesIntf#16)<#16 (comment)>
Rick, Thank you for the pull request. This looks clean to me and I do not see anything that could break the existing hw.
A couple of issues flagged by Claude pull review but these look really minor to me:
* FeedWDT sends an all-zero general-registers packet with a static
sequence number. It works for feeding the watchdog on the boards you
tested, but since it's the general endpoint it also re-writes general config
(e.g. the Alex-enable byte 0x03 set in StartCapture2) to zero every
500ms. Harmless on RP/TRX-DUO, and evidently fine on the ANAN boards -
just flagging it in case a future P2 device relies on that state.
No change needed now.
* long int start_time could be DWORD to match the rest of the file's tick handling,
and the (char*)HERMESLT cast is redundant since other comparisons use the bare
devname == HERMES form.
I'm not sure if P1 is still runs on the most of deployed skimmers (I've been out of the loop lately). Are you able to test a non-HL2 P1 radio (e.g. a plain Hermes) still discovers/starts/streams normally with these changes? You mentioned ANAN P2 and the HL2. I just wanted to make sure sure a standard P1 board isn't affected (it does not look like it would be based the changes).
I'm ok with v143 to v145 bump.
—
Reply to this email directly, view it on GitHub<#16?email_source=notifications&email_token=AAHGUH4KB53EV5JKRTGVFOT5IKPCBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYG4YDAMZUG4ZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5187003472>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHGUH3SH7APBKELQLWSYYL5IKPCBAVCNFSNUABEKJSXA33TNF2G64TZHM4DINJRG4ZTCMR3JFZXG5LFHM2TANJZHE4DMOJZGCQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AAHGUH3RMODQUMUNUMXX6Z35IKPCBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYG4YDAMZUG4ZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/AAHGUH534OLJJKBBTKPIFZ35IKPCBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYG4YDAMZUG4ZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
…ime is now a DWORD,
|
Latest changes tested OK w/ RP - P2 and HL - P1 |
|
Looking good Rick. Thank you. Merging and will do a build and publish the new ver in a bit.. 73! |
- Bump version to 26.8.9 in hermes.rc (FILEVERSION/PRODUCTVERSION + strings) - Add 26.8.9 changelog entry to readme.txt for PR k3it#16 (TRX-DUO/Red Pitaya Protocol 2 fixes, P2 watchdog feed) and PR k3it#17 (fix MAC address DLL filter) - msbuild.yml: upload built HermesIntf.dll as a workflow artifact and auto-attach it to published GitHub releases Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SsVwSNXUxxufvxfb63DbT4
No description provided.