Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prototype a non-replay recovery path for ambiguous Hermes
request_promiseHTTP 5xx responses.Instead of replaying the POST, the provider performs one read-only
GetProviderDatacheck while the serialized Hermes queue entry is still active. It only treats the request as committed when provider identity, provider channel, chain, hashlock and fee all exactly match the request. Otherwise the original error continues through the existing failure counter.The HTTP caller now preserves HTTP status for both recognized and unrecognized Hermes error bodies so generic 5xx can be distinguished from protocol-level errors.
Safety
Open protocol question
Before proposing this upstream as production behavior, Hermes maintainers should confirm that
data/provider/{providerID}.LatestPromiseis sufficiently read-after-write consistent after an ambiguousrequest_promise5xx, and that an exact latest provider-promise hashlock match is a valid commit witness.Related: mysteriumnetwork#6218