Skip to content

Add browser CI workflow - #34

Merged
kawanet merged 1 commit into
kawanet:mainfrom
kawanet-bot:codex/browser-ci
Aug 31, 2026
Merged

Add browser CI workflow#34
kawanet merged 1 commit into
kawanet:mainfrom
kawanet-bot:codex/browser-ci

Conversation

@kawanet-bot

Copy link
Copy Markdown
Contributor

Summary

  • add a Browser CI workflow for pushes to main and manual runs
  • run the existing Mocha browser suite in Chromium through Playwright
  • use Mocha runner stats to require a completed, non-empty test run
  • keep Playwright transient and browser bundle generation outside the normal build
  • preserve browser bundle generation, size checks, cleanup, and benchmark bundles in builder/Makefile

Verification

  • make -C browser install && make -C browser test
  • npm test (65 passed, 6 skipped)
  • make -C builder/pack pack && make -C builder/pack bundled && make -C builder/pack unpack && make -C builder/pack test (36 passed)
  • verified make -C browser clean leaves its delegated bundle intact
  • verified make -C builder clean removes both browser bundles, while make -C builder all recreates the benchmark bundle but not the browser test bundle

Co-authored-by: Codex <noreply@openai.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@kawanet
kawanet requested a balanced review from Copilot August 31, 2026 08:02
@kawanet

kawanet commented Aug 31, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 1d799f9e7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The changes are CI/build infrastructure with external dependencies (Playwright browser download, GitHub Actions, Makefile restructuring) whose green-run behavior cannot be verified through static review and warrants human confirmation.

Pull request overview

This PR adds a dedicated Browser CI workflow that runs the existing Mocha browser test suite headlessly in Chromium via Playwright. It introduces a small browser/Makefile entry point plus a Playwright driver script, adapts browser/tests.html to publish Mocha's run stats so the harness can detect a completed, non-empty, failure-free run, and adjusts builder/Makefile so the browser test bundle is generated on demand (by browser CI) rather than as part of the default all target, while still being cleaned up.

Changes:

  • New GitHub Actions Browser CI workflow (push to main + manual) that installs Playwright transiently and runs the browser suite.
  • New browser/Makefile and browser/tests.cli.mjs Playwright driver that waits for window.mochaStats, and asserts no page errors, no failures, and at least one test.
  • builder/Makefile drops BROWSER_TEST_DST from ALL but adds it explicitly to clean, keeping generation on-demand and cleanup intact.
File summaries
File Description
.github/workflows/browser.yml New workflow running the browser suite in Chromium; versions and node config match the existing nodejs.yml.
browser/Makefile New CI entry point delegating bundle generation to builder, installing Playwright transiently, and running the driver.
browser/tests.cli.mjs New Playwright driver launching headless Chromium and validating Mocha run stats and page errors.
browser/tests.html Captures runner.stats into window.mochaStats on completion for headless detection.
builder/Makefile Removes browser test bundle from all; adds it to clean so cleanup still removes it.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kawanet
kawanet merged commit 85ff53f into kawanet:main Aug 31, 2026
6 checks passed
@kawanet-bot
kawanet-bot deleted the codex/browser-ci branch August 31, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants