tests framework updates - #35
Conversation
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🟡 Changes recommended
The updated browser node:assert shim still uses unguarded JSON.stringify(...) in default assertion messages, which can throw and mask assertion failures.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the project’s test tooling and browser test harness, aligning dependency versions and improving browser-side assertion/shim behavior and CLI output for Playwright-driven Mocha runs.
Changes:
- Bumped package version to
0.12.0and updated devDependencies (notably Mocha, Rollup, Terser). - Refined the browser
node:assertshim messaging/behavior (including a more informativedoesNotThrow). - Improved browser CI ergonomics: browser Makefile now builds explicit artifacts, and the browser test CLI prints a concise stats line.
File summaries
| File | Description |
|---|---|
| package.json | Version bump and test/build tool dependency updates. |
| builder/node-assert.shim.ts | Updates browser-side node:assert shim behavior/messages for test bundles. |
| browser/tests.cli.mjs | Prints Mocha run stats from the browser harness for clearer CLI output. |
| browser/Makefile | Uses named artifact variables and invokes builder to produce required browser test outputs. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| export const strict = { | ||
| // Mirrors `assert.ok(value, message?)`. | ||
| // Truthy check. Mirrors `assert.ok(value, message?)` in node:assert. | ||
| ok(value: unknown, message?: string): void { | ||
| if (!value) { | ||
| throw new Error(message || "expected truthy, got " + JSON.stringify(value)) | ||
| throw new Error(message || `expected truthy, got ${JSON.stringify(value)}`) |
@codex review