Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS currently polls AVFoundation for video dimensions for five seconds. Valid remote media whose dimensions arrive later cannot opt into a longer window and may report
Failed to retrieve video size.This adds a positive, configurable dimension-polling timeout while retaining the existing 5,000 ms default, 250 ms polling cadence, duration polling, and initialization timeout. Desktop callers can use:
The setting is also available through
DefaultVideoPlayerState(macVideoDimensionsTimeoutMillis = ...)andMacVideoPlayerState(videoDimensionsTimeoutMillis = ...). Existing no-argument constructors remain available. The desktop Compose overload disposes its state when removed or when the configured value changes; Windows and Linux retain their existing playback behavior.Longer dimension polling stops when an open is superseded or the player is disposed. A superseded open cannot clear the current open's loading state.
Validation: