ci: target the main branch instead of mainline#28
Open
bhcopeland wants to merge 5 commits into
Open
Conversation
The workflows referenced a mainline branch that does not exist in this repository; the default branch is main. Basic CI and CodeQL are gated on `branches: [ mainline ]`, so they never triggered for pull requests targeting main. The coverage check runs on all branches, but failed at `git checkout origin/mainline` before it could measure anything. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Basic CI has never run against this repository, so the tree has drifted
out of line with .flake8 and .pylintrc. Fix the violations so the lint
job can pass:
F541 f-string without placeholders (cli.py)
E501 line too long (cli.py)
W391 blank line at end of file (artifacts.py)
F401 unused imports (pull_labs_poller.py, test_pull_labs_translate.py)
E306 missing blank line before nested definition (test_kcidb_submit.py)
W0714 overlapping excepts, JSONDecodeError derives from ValueError
(setup_validate.py)
W0613 unused argument (test_kcidb_submit.py)
W0212 protected access in tests (test_role_manager.py)
These changes are extracted unmodified from PR kernelci#26 by Norbert Manthey,
which fixes them alongside its feature work.
Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
pylint reports E0401 import-error for pandas, matplotlib and seaborn in the analysis package, because the dev extra does not install them and CI only installs ".[dev]". Add them to dev so lint can resolve the imports. Also set long_description_content_type, so the README renders as Markdown rather than plain text. Extracted unmodified from PR kernelci#26 by Norbert Manthey. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Commit 46d885e routed results through maestro and disabled direct kcidb submission, but left test_per_instance_rows_carry_log_url_and_stable_test_id asserting on the rows passed to submit_tests. Nothing calls submit_tests any more, so the test fails with KeyError: 'rows'. It went unnoticed because Basic CI never ran. Assert on the node outcome instead: log URLs now reach send_kcidb via artifacts.test_log and test_log_N, and the aggregated result is "fail" when any instance fails. The dropped assertions on stable test ids and misc.instance_id covered the disabled submit_tests path. Also fix the F401 and E127 violations in this file. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
fix-ci-branch-name
branch
from
4365044 to
9168508
Compare
Member
Author
|
@nmanthey just FYI, I was looking at my LTP and fixed up the CI. But also noticed you have fixes in yours. To keep the PR's clean I recommend we push this through and then keep your PR's to features (we can just rebase) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflows referenced a mainline branch that does not exist in this repository; the default branch is main.
Basic CI and CodeQL are gated on
branches: [ mainline ], so they never triggered for pull requests targeting main. The coverage check runs on all branches, but failed atgit checkout origin/mainlinebefore it could measure anything.