Repository navigation
fix: delete every cached item of a profile, including zsh-op leftovers - #31
Merged
Merged
Conversation
`keysafe profile clear` deleted only the secrets named in the config or the loaded metadata, so items zsh-op cached under op-secrets-<profile> for secrets no longer configured stayed in the keychain forever. Clear now also searches the keychain for every item under keysafe.<profile> and op-secrets-<profile> (attributes only, no prompts) and deletes them. `keysafe doctor` warns when zsh-op items remain for a configured profile and says how to remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keysafe profile clearonly deleted secrets named in the config or the loaded metadata, so items zsh-op cached underop-secrets-<profile>for secrets no longer configured stayed in the keychain.SecretStore::accountslists the item names under a service by searching the keychain (attributes only, never prompts).profile cleardeletes every item under bothkeysafe.<profile>andop-secrets-<profile>.doctorwarns:! Keychain: 8 items left from zsh-op under op-secrets-personal (remove them with \keysafe profile clear personal`)`.